Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OP Plasma] Specify commitment encoding standards for generic server types #229

Open
epociask opened this issue Jun 7, 2024 · 0 comments

Comments

@epociask
Copy link

epociask commented Jun 7, 2024

Alt da servers (I.e, generic commitment types) are expected to encode the type byte prefix as per the server side generated commitment for the client to decode when querying. Additionally these servers are expected to decode the type byte when reading (i.e, /GET).

The spec should likely be updated to reflect this server side encoding/decoding requirement. Otherwise it may make sense to only do the type encoding within core OP services. Currently the commitment is decoded in the da client to then be re-encoded when setting the tx data byte resulting in a redundant encoding operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant