Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inverted Width/Height on 2x IIIF V3 Manifests #170

Open
DiegoPino opened this issue Mar 25, 2022 · 1 comment
Open

Inverted Width/Height on 2x IIIF V3 Manifests #170

DiegoPino opened this issue Mar 25, 2022 · 1 comment
Assignees
@DiegoPino
Labels
bug Something isn't working Twig {% burp %}

Comments

@DiegoPino
Copy link
Member

What?

RC3 made me cry and I ended inverting "width" and "height" values on 2 manifests
This are the based IIIF V3 and the IIIF V3 Child Canvas one. I made 2 direct pulls for this (since really tracking this diffs on a single long line is evil)

and

d88630a
3f25cad

Really hope I got this right?
@alliomeria @patdunlavey
@DiegoPino DiegoPino added bug Something isn't working Twig {% burp %} labels Mar 25, 2022
@DiegoPino DiegoPino self-assigned this Mar 25, 2022
@DiegoPino DiegoPino mentioned this issue Mar 25, 2022
Closed
@patdunlavey
Copy link
Contributor

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoPino DiegoPino

Labels
bug Something isn't working Twig {% burp %}
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patdunlavey @DiegoPino