Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SentMessageClient class missing #16

Open
brilnius opened this issue Dec 28, 2016 · 1 comment
Open

SentMessageClient class missing #16

brilnius opened this issue Dec 28, 2016 · 1 comment

Comments

@brilnius
Copy link

Glad to have found this gem! :-)

When using the example in readme:
result = account.sent_messages
I got this exception:
NameError: uninitialized constant Esendex::Account::SentMessageClient

After a glance at the change history, it seems SentMessageClient was indeed removed some time ago.
What was the reason? Is SentMessageClient supposed to "come back" one day?
If not, the readme should be updated (and also remove the Account.sent_messages method).

@moretonb
Copy link

Hi @brilnius

Thank you for the feedback! It looks like we inadvertently introduced a regression merging in quite an old PR. I'll raise a bug card once I've had a chat with people in the team when I'm not quite so lonely in the office. It's a little quiet until January heh.

I'll also keep you posted and update the issue with the outcome once I know what direction we're taking with this. Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants