Maintainers Sync - 2021-11-26

[robertoaloi]

Alan/Roberto/Andreas/Robert Fiko

• Roberto spoke to Simon Thompson re Wrangler
  • Assumption wrangler should not be part of the code base
  • Use the same mechanism as refactorerl, some kind of RPC
  • Wrangler group going to focus on vscode plugin directly
  • Roberto having a session next week re integration
• Refactoring commands
  • LSP only accepts user input for rename, part of the spec
  • Other commands must be via code actions, and put in a made up name, like “new_func1”.
  • This can send an execute-command call, with the preset name param in it
    • Something like in emacs-lsp/lsp-haskell@c0a56a6#diff-4d2f95291a5d0fb0ce5bc04432df09306fc0a22e3abcffa10376c4b56843d3d9
  • But we can send that command under control of the UI, which then allows input
  • In VsCode the command palette allows setting up a command, which can do input etc
  • Wrangler and Refactorerl have scripting languages. How to leverage.
    • Perhaps use something like the approach in https://github.com/ag91/moldable-emacs
• VsCode has introduced proper error reporting if an extension fails to start
  • Based on Roberto input to VsCode
• Diagnostic code allocation gave bad result for dodgy parse transform
  • [1140] Do not include error description in code #1141
• Roberto adding support for deprecated functions in UI
  • deprecated things end up with strike through, via deprecated tag
  • Support showing deprecated completion items emacs-lsp/lsp-mode#2904
  • OTP has list of deprecation
  • -deprecated attribute only applies to xref
• Andreas started looking at the BSP again
  • Looks like overkill for some things
• Performance: Hover caused delays
  • edoc processing inline
  • Fix was to use cached results for hover request only, return immediatley with what is available
  • No longer a problem, can make a new erlang_ls release
• Edoc in general is dodgy
  • Should be able to call it for a single function
• Robert Fiko hit an erlang_ls crash doing os:command