Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in NavigationRouteConfigurationExtensions #75

Open
nwoolls opened this issue Feb 28, 2013 · 1 comment
Open

Bug in NavigationRouteConfigurationExtensions #75

nwoolls opened this issue Feb 28, 2013 · 1 comment

Comments

@nwoolls
Copy link

nwoolls commented Feb 28, 2013

Since the source for the NavigationRoutes stuff is no longer in the repo I cannot check to see if this is fixed, but it looks like it was still an issue when the code was moved into its own package and it's still an issue with the NuGet packages.

With the current code, if you have other actions under the Home controller besides Index, their links will be rendered incorrectly in the navigation bar and will generate a 404. For instance, instead of http://localhost/home/test the URL is http://localhost/test. This is pretty easy to reproduce with the sample project by adding another action to the Home controller, with a View, and then registering that with the navigation routes.

Commenting out the else condition in NavigationRouteConfigurationExtensions.CreateUrl(string actionName, string controllerName) fixes this problem.

@RhysC
Copy link

RhysC commented Apr 27, 2013

Bump. The "Commenting out the else condition" fix looks good too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants