setup.py does not require flask

[dgabbe]

Setup.py is missing a stanza to require flask.

[dgabbe]

Travis works because it installs modules listed in requirements.txt.

[eric-s-s]

as an additional fix, first remove the install of requirements.txt from the .travis.yaml and watch the build fail. then fix

[ragnarokatz]

@eric-s-s hello, I would like to give this issue a try please.

[ragnarokatz]

reference pull request #7

[eric-s-s]

@ragnarokatz Excellent and welcome!

[eric-s-s]

as you'll note in the conversation above, first I want to make sure that the travis build will properly fail without the install_requires field. This means first editing the .travis.yaml file so that it doesn't install requirements.txt. Once that build fails, then add the install requires lines and (hopefully) watch it pass on the next build.

[ragnarokatz]

hello @eric-s-s, I have removed both the install_requires field from setup.py, as well as removed the pip install -r requirements.txt line from .travis.yaml. as a result, all checks have failed.

now I will proceed to add back the install_requires field to setup.py file and hopefully all checks will pass.

[ragnarokatz]

nope, still fails:

@eric-s-s
should I add the pip install -r requirements.txt line back in? or do you prefer a different solution?

[eric-s-s]

definitely a different solution. if you look at the build report, everything loaded fine, and there's some other problem.

[dgabbe]

Eric,

Something to try as I think you mentioned it was a breaking change to Flask is to add a constraints.txt to the project to control which version requirements.txt will install if needed.

[Jabbing31]

as an additional fix, first remove the install of requirements.txt from the .travis.yaml and watch the build fail. then fix