-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zipkin follow ups #960
Comments
@mattklein123 Your list sounds like a great starting point for improvements. I should be able to start tackling that next week. |
Is there some plan to filter or sample traces for zipkin? |
@kyessenov what do you mean exactly? Sampling is already supported (only via runtime, can be trivially added to the config). What do you mean by filtering? |
btw, part 3 of this is done.. #993 |
… On Fri, Jun 9, 2017 at 2:44 AM, Shriram Rajagopalan < ***@***.***> wrote:
btw, part 3 of this is done.. #993
<#993>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#960 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD61-1sc1-JpG2ARZh-SbTo5Ei-_ACGks5sCED-gaJpZM4NafuH>
.
|
anybody want to update zipkin's website to show envoy support is in?
https://github.com/openzipkin/openzipkin.github.io/blob/master/_data/community_instrumentations.yml
|
@mattklein123 I think filtering refers to excluding endpoints that you probably don't want to trace such as admin resources or health check endpoints. Would be helpful for this istio issue. |
Hi, @flier I know this isn't your code, but since you are helping with zipkin in c/c++.. There are a lot of users who'd like this issue to be improved, but less people actively improving. If you can lend a hand, it would be very appreciated. |
@adriancole sure, let me check it later |
@mattklein123 , can you point me to a sample code or a documentation that shows how to configure these sampling options? Thx |
Here are the runtime settings: https://www.envoyproxy.io/docs/envoy/latest/configuration/http_conn_man/runtime Work is ongoing to make these config settings also: #1813 |
Closing this out as I don't think it's worth tracking the small items here anymore and we have several examples use Jaeger. |
We should be using bazelisk on CI since that's what we advise doing locally. Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
We should be using bazelisk on CI since that's what we advise doing locally. Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
Might be a few other things missing. Feel free to add.
cc @adriancole @timperrett @rshriram @fabolive
The text was updated successfully, but these errors were encountered: