Zipkin follow ups

[mattklein123]

• JSON interface TODO
• Perf pass
• End to end docker example would be super amazing (https://lyft.github.io/envoy/docs/install/sandboxes.html)

Might be a few other things missing. Feel free to add.

cc @adriancole @timperrett @rshriram @fabolive

[fabolive]

@mattklein123 Your list sounds like a great starting point for improvements. I should be able to start tackling that next week.

[kyessenov]

Is there some plan to filter or sample traces for zipkin?

[mattklein123]

Is there some plan to filter or sample traces for zipkin?

@kyessenov what do you mean exactly? Sampling is already supported (only via runtime, can be trivially added to the config). What do you mean by filtering?

[rshriram]

btw, part 3 of this is done.. #993

[codefromthecrypt]

looks great https://twitter.com/zipkinproject/status/873065607826071553

…

On Fri, Jun 9, 2017 at 2:44 AM, Shriram Rajagopalan < ***@***.***> wrote: btw, part 3 of this is done.. #993 <#993> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#960 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD61-1sc1-JpG2ARZh-SbTo5Ei-_ACGks5sCED-gaJpZM4NafuH> .

[codefromthecrypt]

anybody want to update zipkin's website to show envoy support is in? https://github.com/openzipkin/openzipkin.github.io/blob/master/_data/community_instrumentations.yml

[mclarke47]

@mattklein123 I think filtering refers to excluding endpoints that you probably don't want to trace such as admin resources or health check endpoints. Would be helpful for this istio issue.

[mclarke47]

I think that another follow up action should be to support 128 bit trace ids (details reasons).

[codefromthecrypt]

Hi, @flier I know this isn't your code, but since you are helping with zipkin in c/c++.. There are a lot of users who'd like this issue to be improved, but less people actively improving. If you can lend a hand, it would be very appreciated.

[flier]

@adriancole sure, let me check it later

[marqub]

Is there some plan to filter or sample traces for zipkin?

@kyessenov what do you mean exactly? Sampling is already supported (only via runtime, can be trivially added to the config). What do you mean by filtering?

@mattklein123 , can you point me to a sample code or a documentation that shows how to configure these sampling options? Thx

[mattklein123]

Here are the runtime settings: https://www.envoyproxy.io/docs/envoy/latest/configuration/http_conn_man/runtime

Work is ongoing to make these config settings also: #1813

[mattklein123]

Closing this out as I don't think it's worth tracking the small items here anymore and we have several examples use Jaeger.