(Possibly only temporarilly) invalid gbfs.json are cached and will only be updated on Lamassu restart

[hbruch]

Expected behavior

Lamassu should not subscribe successfully to a system, which does not publish a valid gbfs.json.
(Ideally, gbfs.json should be reloaded periodically to detect new/changed upstream feed declarations)

Observed behavior

The gbfs.json file of a system is requested once on startup, and, if parseable, cached, even if it does not declare all required feeds (e.g. has system_information missing). It can only be refreshed via a Lamassu restart.

(One of our providers temporarily published incomplete gbfs.json files wich did not contain a system_information feed).

See also entur/gbfs-validator-java#90 for improved gbfs.json validation rules.

Version of lamassu used (exact commit hash or JAR name)

2195466

Data sets in use (links to GBFS feeds)

N.A. (meanwhile the corrupt gbfs.json is fixed by provider)

How to reproduce

Try to import a feed with a gbfs.json like:

{"last_updated":1719298781,"ttl":60,"version":"2.3","data":{"en":{"feeds":[{"name":"gbfs","url":"http://localhost:8000/gbfs/v2/myfeed/gbfs"},{"name":"geofencing_zones","url":"http://localhost:8000/gbfs/v2/myfeed/geofencing_zones"}]}}}

and change the gbfs.json after lamassu is started. Lamassu will continue to publish the initially loaded, incorrect gbfs.json.