You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should rename the GuiTestAssistant (the one in Traits Futures, not the one in Pyface) to avoid confusion, polish it up, document it, and make it available to users, possibly under a new traits_futures.testing.api module.
👍 on renaming. The core of this is a dependency of an event loop, in theory, any event loop (e.g. it can be asyncio or tornado event loop in the context of a web server). Reading GuiTestAssistant in a test case that is not targeting GUI raises false alarm.
Yes, renaming is a no-brainer. (The existing name is historical: at one point the GuiTestAssistant we were using actually was the Pyface version, then it was a cut-down version of the Pyface version, then a modified cut-down version, extended to cover wx and asyncio, .... It's definitely due a rename.)
Note that there are also some pending changes in #299, which will make the GuiTestAssistant toolkit independent and move the underlying event loop management into a toolkit dependent piece.
We should rename the
GuiTestAssistant
(the one in Traits Futures, not the one in Pyface) to avoid confusion, polish it up, document it, and make it available to users, possibly under a newtraits_futures.testing.api
module.See also #252.
Subtasks:
GuiTestAssistant
: Rename GuiTestAssistant to TestAssistant #388GuiTestAssistant
GuiTestAssistant
totraits_futures.testing.api
, and add tests fortraits_futures.testing.api
.The text was updated successfully, but these errors were encountered: