Add comments to metaclasses. #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Oct 7, 2024
to `_coclass_meta.__new__`.
to `_cominterface_meta.__new__`.
junkmd
force-pushed
the
add_comments_to_metaclasses
branch
from
b1b9810
to
4900009
Compare
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the investigation for #618, I noticed that one metaclass had comments while the other didn't, so I added the missing comments.
Additionally, I found some implementations that seem to be remnants from the time when Python 2.x was supported, so I added
# HACKcomments.I plan to open issues regarding these matters soon.