Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing tool.ruff.lint.per-file-ignores. #643

Open
junkmd opened this issue Oct 21, 2024 · 0 comments
Open

Reducing tool.ruff.lint.per-file-ignores. #643

junkmd opened this issue Oct 21, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@junkmd
Copy link
Collaborator

junkmd commented Oct 21, 2024

We are looking to reduce the number of rules ignored in tool.ruff.lint.per-file-ignores by delinting the codebase. This is a great opportunity for new contributors to get involved!

Guidelines:

  • We welcome delinting of one rule per file, or keeping changes as small as possible per pull request, as it makes it easier for reviewers to check the changes.
  • If your PR addresses multiple rules or files, reviewers might consider it a large change and suggest splitting it into multiple PRs.
  • When modifying runtime codebases, be careful not to break backward compatibility. For example, when delinting E722 'bare-except', specifying the type of exception to catch may result in different behavior before and after the change.
  • If you want to delint without changing the implementation, use the minimal # noqa: RULE comments.
@junkmd junkmd added the good first issue Good for newcomers label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant