Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type definitions for Request and Response #9742

Open
edloidas opened this issue Sep 27, 2022 · 9 comments · May be fixed by #10724
Open

Add type definitions for Request and Response #9742

edloidas opened this issue Sep 27, 2022 · 9 comments · May be fixed by #10724
Assignees
Labels

Comments

@edloidas
Copy link
Member

edloidas commented Sep 27, 2022

Add Request and Response types under the lib-portal types.

Page requests doesn't have contextPath

@edloidas edloidas added the Bug label Sep 27, 2022
@edloidas edloidas added this to the 7.11.0 milestone Sep 27, 2022
@edloidas edloidas self-assigned this Sep 27, 2022
@edloidas edloidas changed the title Add web types Add Request and Response to lib-portal Sep 27, 2022
@rymsha rymsha added Bug and removed Improvement labels Sep 28, 2022
@rymsha rymsha modified the milestones: 7.11.0, 7.12.0 Sep 29, 2022
@rymsha rymsha added Feature and removed Bug labels Dec 14, 2022
@rymsha rymsha changed the title Add Request and Response to lib-portal TS Add Request and Response to lib-portal Dec 19, 2022
@alansemenov alansemenov removed this from the 7.12.0 milestone Feb 27, 2023
@ComLock
Copy link
Member

ComLock commented Apr 14, 2023

It would be nice if Request headers keys are stricter than string so code will be future proof for HTTP/2.

8.1.2.6. Malformed Requests and Responses

A malformed request or response is one that is an otherwise valid
sequence of HTTP/2 frames but is invalid due to the presence of
extraneous frames, prohibited header fields, the absence of mandatory
header fields, or the inclusion of uppercase header field names.

@ComLock
Copy link
Member

ComLock commented Apr 14, 2023

@ComLock
Copy link
Member

ComLock commented Apr 14, 2023

@ComLock
Copy link
Member

ComLock commented Apr 14, 2023

I keep forgetting there is no such thing as lowercasestring in typings yet.

@ComLock
Copy link
Member

ComLock commented Apr 19, 2023

@ComLock
Copy link
Member

ComLock commented Oct 1, 2024

I think what needs to be done here is find some real life examples to test the Request and Response types against.

ComLock added a commit that referenced this issue Oct 2, 2024
@ComLock ComLock linked a pull request Oct 11, 2024 that will close this issue
@alansemenov alansemenov changed the title TS Add Request and Response to lib-portal Add type definitions for Request and Response Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants