Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor utils default export adapterConstants #443

Open
ComLock opened this issue Jan 9, 2024 · 0 comments
Open

refactor utils default export adapterConstants #443

ComLock opened this issue Jan 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ComLock
Copy link
Member

ComLock commented Jan 9, 2024

ASFAIK adapterConstants isn't exported by index.ts, so it's use is only internal.
Since the code is currently in the module scope, it will run on load, which means the module has "side-effects".
This doesn't smell well and should be refactored somehow.
@ComLock ComLock added the enhancement New feature or request label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ComLock