New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserTreeGridItemType is obsolete #731

Open

poi33 opened this issue Sep 20, 2021 · 1 comment

Labels

poi33 commented Sep 20, 2021 •

edited by alansemenov

Loading

app-user's UserTreeGridItem.ts
The enum UserTreeGridItemType has 5 roles
ID_PROVIDER,
PRINCIPAL,
GROUPS,
USERS,
ROLES

lib-admin-ui's PrincipalType.ts
Uses 3 roles.
USER,
GROUP,
ROLE

Remove the PRINCIPAL role and add the ID_PROVIDER to the principalType.
Then use the principalType so it is not confused with different enum type.

Author

poi33 commented Sep 20, 2021

Branch issue-725-fix already fixed a enum conflict.

alansemenov added the Refactoring label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment