wrong types - module:modulename/typename turned into just module

[greggman]

I have jsdocs that look like

    /**
     * Creates a framebuffer and attachments.
     *
     * @param {WebGLRenderingContext} gl the WebGLRenderingContext
     * @param {module:twgl.AttachmentOptions[]} [attachments] which attachments to create.
     * @param {number} [width] the width for the attachments. 
     * @param {number} [height] the height for the attachments.r
     * @return {module:twgl.FramebufferInfo} the framebuffer and attachments.
     * @memberOf module:twgl/framebuffers
     */

tsd-jsdoc 2.1.3 generated the correct (or at least useful for me) signature

    function createFramebufferInfo(
        gl: WebGLRenderingContext,
        attachments?: module:twgl.AttachmentOptions[],
        width?: number,
        height?: number): module:twgl.FramebufferInfo;

tsd-jsdoc 2.2.0+ generates an incorrect signature

    function createFramebufferInfo(
        gl: WebGLRenderingContext,
        attachments?: module[],
        width?: number,
        height?: number): module;

[englercj]

attachments?: module:twgl.AttachmentOptions[],

I don't think that is valid Typescript, is it? I definitely get errors on the playground trying to use it.

I agree the new one is incorrect as well. Assuming twgl is a module you have somewhere else in code I'd expect the output to just be twgl.FramebufferInfo. PR welcome!

[greggman]

Yea, I agree the old output was wrong but I had some post process to fix it. Now the output is unusable though.

[greggman]

Well look into PR if someone doesn't beat me to it. For now just moved my deps back to 2.1.2

[bkuster]

So, I've been having the same issue and decided to try changing modules to imports, e.g. something like this:

if (/^module:/.test(name)) {
  const [mod, imp] = name.replace(/^module:/, '').split('~');
  return ts.createImportTypeNode(ts.createStringLiteral(mod), ts.createTypeReferenceNode(imp || 'default'));
}

This turns:

/**
 * @typedef {Object} Options
 * @property {module:ol/coordinate~Coordinate} coords
 * @property {module:cesium~CesiumTerrainProvider} terrain
 */

into

declare type Options = {
    coords: import("ol/coordinate").Coordinate;
    terrain: import("cesium").CesiumTerrainProvider;
};

Thoughts?