-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bazel] Should the toolchain set the same variables as tools/building.py? #1397
Comments
It's not quite intentional. The toolchain is much older than github commit history would lead you to believe. When it was set up, it was with a much older version of bazel, and we simply did what we needed to to get it working. Are you seeing specific errors because these are unset? |
It was arguably more a problem in CPython, but indeed the difference between having |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When testing with a dummy configure script, I can see that the following variables are set correctly:
CC
,CXX
,AR
,LD
However these values are left blank, while they are set in tools/building.py:
NM
,LDSHARED
,RANLIB
,EMSCRIPTEN_TOOLS
,HOST_CC
,HOST_CXX
,HOST_CFLAGS
,HOST_CXXFLAGS
,PKG_CONFIG_LIBDIR
,PKG_CONFIG_PATH
,EMSCRIPTEN
,PATH
,ACLOCAL_PATH
,CROSS_COMPILE
.Is this intentional? I would have expected that the toolchain sets up Bazel in a way that running bare
configure
is the same asemconfigure
.The text was updated successfully, but these errors were encountered: