-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trace.h dead? #18121
Comments
3 more libraries:
|
I don't know if the framework has many users. Certainly there only seems to be one very basic test that uses it: I believe this library was originally written by @waywardmonkeys back in 2014, so perhaps he has some insight? Are you still using this library bruce? How about @juj, do you use this library? |
I think it is lack of mantainance. I've used it for some time, mainly to find memory leak. |
It also does not work if It seems https://emscripten.org/docs/api_reference/trace.h.html should be deleted. Its presence is misleading. |
I no longer work for the people that I wrote this for ... I could perhaps look at updating some parts of it ... but maybe there are better ways to do it all now these days? |
Given that we have lsan for leak detection these days and it doesn't seem like there is anyone using this, I think this might be good feature to consider for removal. Perhaps (I hope) this is the kind of thing that could be built on top of emscirpten rather than within it? |
I have the time, so I'll submit a PR that removes this. :) |
So, the |
I'm not aware of any users, but I have maintained it over time. If nobody is using it, it would be great to remove it. If folks are using it ... then perhaps we can reduce the tracing support to use the memory profiler and remove the public interface to it. |
--memoryprofiler (and --cpuprofiler and --threadprofiler) are definitely being used! |
I've also just spent a bit of time trying to get tracing to work (tried Address Sanitizer first, but failed to get it to work with our code base, so moved on to try trace). I agree - or at the very least, give a warning at the top of the tracing doc that points here. |
https://emscripten.org/docs/api_reference/trace.h.html
Here are 3 ways of using this library:
Page reload loop when recording URL using WTF google/tracing-framework#589
Here is a fork https://github.com/feserr/emscripten-trace-collector and it works with python3 but this whole server has ugly GUI and also it doesn't gives an ability to save the report to open it in google framework GUI
The third way has just worked for me but it requires manually adding these scripts into debug builds which isnt really easy to use
The text was updated successfully, but these errors were encountered: