Allow (manually) populating video URLs mid-event #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing, updating the frab schema is a bunch of fiddly stuff I was dreading having to do! I think we can probably manage without a separate role, but we'll probably add a bunch more granular permissions at some point. |
|
For the record, this fixes part of #831 |
Imported at https://github.com/voc/schedule/blob/89a4a34c78f2df8111e65164c9acce110313fe6d/validator/xsd/schedule.xml.xsd Incidental changes: * day start is now required, so populate it * Tests need to use timezone aware datetimes or we produce XML timestamps with no UTC offset, which is invalid * Change the tests to use assert_, so that errors are reported by pytest rather than just reporting "False"
This should(?) maybe(?) make media.ccc.de point back to the event page on the Fahrplan link for each video.
lukegb
force-pushed
the
video-shenanigans
branch
from
47d7955
to
0cc84f3
Compare
|
I think this is actually ready for review; I think it remains to be seen how we'll actually end up pushing video URLs but this at least allows someone to yank/correct them manually if things go wrong. |
marksteward
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment this is only accessible to CfP admins; maybe we should add a separate role/form for people who are allowed to attach uploaded videos to (accepted) proposals?
This also makes the talk URL visible in the frab XML (which will hopefully mean that media.ccc.de will link back to the talk's page) and updates a few bits to bring things into sync with c3voc's latest copy of the schema.