-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Allow matching on individual categories #363
Comments
My reading of the spec says that this isn't actually a feature, but that you're just giving it a category of the literal name |
I can't find it explicitly stating in the spec if it is or isn't supported like it seems to suggest in the man-page and code. It is clearly all ending up in the In regards to In regards to resolving this with supporting regex for this field, that would work for simple |
I'm going to close this as "won't implement". The category is a string, so I'm fine with adding string matching operations, but I'd rather not split on commas. Feel free to send a PR for regexp support. |
Currently the criteria matching for
category
checks the whole category string but thenotify-send
man-page suggests supplying multiple using comma separation.(fwiw, the same also applies to
icon
)It would be nice if it was possible to define criteria on one or a combination of the defined comma-separated categories instead of handling it as one single big category.
E.g. for
notify-send -c mycustom1,mycustom2,mycustom3 ...
, sections[category=mycustom1]
,[category=mycustom2]
and[category=mycustom1,mycustom3]
would qualify. For configuration properties that exist in multiple, the most exact/complete match should take precedence (so in this example, the property set in the last one).The matching part could potentially also/already be covered with #306 but
as far as I understand things there is nothing like priority matching (I think it's currently just whatever matches first?) andsince there is no ordering for the categories, setting up a regex to cover the different combinations would be a pain in the a** 😅EDIT: Just saw the part in the man-page saying the last match will take so I suppose accounting for the ordering in your config file yourself would cover the priority matching by being smart about it.
The text was updated successfully, but these errors were encountered: