Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waiter.nextToken needs to be added to the production Noop waiter #462

Open
runspired opened this issue Oct 26, 2023 · 1 comment
Open

waiter.nextToken needs to be added to the production Noop waiter #462

runspired opened this issue Oct 26, 2023 · 1 comment

Comments

@runspired
Copy link

the only way to pass a label to beginAsync is to also pass a token yourself, meaning:

waiter.beginAsync(waiter.nextToken(), myLabel)

in production builds this will throw because the no-op waiter does not stub this function

@NullVoxPopuli
Copy link
Contributor

any chance you'd be willing to add a separate test app here: https://github.com/emberjs/ember-test-waiters/tree/master/test-apps

that tests and asserts production behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants