Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Label text escaping is broken #1193

Open
3 tasks done
w-lfchen opened this issue Sep 7, 2024 · 0 comments · May be fixed by #1194
Open
3 tasks done

[BUG] Label text escaping is broken #1193

w-lfchen opened this issue Sep 7, 2024 · 0 comments · May be fixed by #1194
Labels
bug Something isn't working

Comments

@w-lfchen
Copy link
Contributor

w-lfchen commented Sep 7, 2024

Checklist before submitting an issue

  • I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
  • I have specifically verified that this bug is not a common user error
  • I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug

the label doesn't show up, the log states Failed to unescape label text

Reproducing the issue

this can happen by statically putting \\ in a label text.
this issue can be resolved by changing this to \\\\, but this is not feasible for every script.

Expected behaviour

it doesn't break

Additional context

the culprit here is the unescape crate, it is being used here.
this forces every escape in yuck to happen twice if the result should be put in a label.
i'll see whether i can file a pr to improve things.

a fix addressing this should also close #1117 (and maybe other issues)

@w-lfchen w-lfchen added the bug Something isn't working label Sep 7, 2024
@w-lfchen w-lfchen linked a pull request Sep 7, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant