Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): add spell checker #4

Open
JaeAeich opened this issue Sep 16, 2024 · 2 comments
Open

feat(common): add spell checker #4

JaeAeich opened this issue Sep 16, 2024 · 2 comments

Comments

@JaeAeich
Copy link
Collaborator

Add spell checker as common action instead of language specific so we can rely on only one dep that can be used to cross language.

@uniqueg
Copy link
Member

uniqueg commented Oct 4, 2024

Not really important for now, I guess, but perhaps it would be good to have a common spellchecker method and dictionary, but the ability to extend with custom dictionary for each repo.

@JaeAeich
Copy link
Collaborator Author

JaeAeich commented Oct 4, 2024

yeah, my point for this was that the current setup for actions, I have been taking reference to, is from cookicutter, so while writing CI for python, I only configured spell checker in python, which didn't make sense (as I was simultaneously wrting CI for rust), so I thought why not use the same dep (be it python, rust, node, or even C) for all the repo as this action should be language agnostic.

So the current changes that I am making is, for poetry setup action which used to have fields like install-options etc to take in groups from pyporject to install, I am planning on adding feat to install independent dep so that when we can install the same dep (say typos that we use for python) in rust projs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants