Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualize embeddable] Custom panel title not being saved for by value embeddables #199882

Open
patodevilla opened this issue Nov 12, 2024 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. regression Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@patodevilla
Copy link

patodevilla commented Nov 12, 2024

Kibana version: 8.16.0

Elasticsearch version: 8.16.0

Server OS version: Elastic Cloud

Browser version: Chrome

Browser OS version: 130.0.6723.117

Original install method (e.g. download page, yum, from source, etc.): download

Describe the bug: After configuring a panel title and saving the dashboard, the data is lost after refresh. This issue is important since it deletes title configuration of existing dashboards.

Steps to reproduce:

  1. Create new dashboard
  2. Click "Add panel" and select "Aggregation base"
  3. Create visualization and click "Save to library"
  4. Click panel settings and give panel custom title
  5. saved dashboard
  6. reload dashboard. Notice how panel custom title is getting overwritten by title saved from visualization saved object.
    Expected behavior: Panel title settings to be saved

Screenshots (if relevant):

Image

@patodevilla patodevilla added the bug Fixes for quality problems that affect the customer experience label Nov 12, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 12, 2024
@mbondyra mbondyra added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor

nreese commented Nov 15, 2024

I updated the re-creation steps to include details

  1. visualization type "agg based"
  2. saved by-value
  3. with custom title. Saved object title is displayed instead of custom panel title.

@nreese nreese added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Nov 15, 2024
@nreese nreese changed the title Dashboard panel title not being saved [Visualize embeddable] Custom panel title not being saved for by value embeddables Nov 15, 2024
@nreese nreese added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@nreese
Copy link
Contributor

nreese commented Nov 15, 2024

Added impact:high label because saving a dashboard with by-value visualize embeddables with custom titles will lose custom title state.

Added Team:visualization label because problem exists in visualize embeddable serializeState method. By value embeddables do not store titles state. This information is then lost on save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. regression Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants