Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] UB in revm (dup opcode impl) #685

Open
sergey-melnychuk opened this issue Jun 18, 2024 · 0 comments
Open

[Tracking] UB in revm (dup opcode impl) #685

sergey-melnychuk opened this issue Jun 18, 2024 · 0 comments

Comments

@sergey-melnychuk
Copy link
Collaborator

sergey-melnychuk commented Jun 18, 2024

Non-actionable at this point unfortunately. Helios needs to bump revm to a fixed version, then we can bump Helios - not much we can do but just wait until it happens.

(TODO: report bug to Helios)

$ cargo run ...
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.31s
     Running `target/debug/beerus -c tmp/mainnet.toml`
2024-06-18T18:06:47.941326Z  INFO beerus::eth: syncing head=9325832
2024-06-18T18:06:48.942822Z  INFO beerus::eth: syncing head=9325832
2024-06-18T18:06:49.945598Z  INFO beerus::eth: syncing head=9325832
2024-06-18T18:06:50.385735Z  INFO helios::consensus: updated head               slot=9325830  confidence=99.80%  age=00:00:00:27
2024-06-18T18:06:50.947096Z  INFO beerus::eth: syncing head=9325832
2024-06-18T18:06:51.103744Z  INFO helios::consensus: consensus client in sync with checkpoint: 0x18f9e211b55001806236375b4188e9a47654e53fde5023f4a93f08006c29e16a
2024-06-18T18:06:51.949148Z  INFO beerus::eth: syncing head=9325832
2024-06-18T18:06:52.951144Z  INFO beerus::eth: syncing head=9325832
thread 'main' panicked at library/core/src/panicking.rs:156:5:
unsafe precondition(s) violated: slice::get_unchecked_mut requires that the index is within the slice
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread caused non-unwinding panic. aborting.
Aborted (core dumped)

https://github.com/bluealloy/revm/blob/4763c8b1af5e0422f3c55dadbd86bc755399f8d9/crates/interpreter/src/interpreter/stack.rs#L241
bluealloy/revm@50726f3#diff-a41333b95fc9bbd7963b498696145114471dd84e96e6fa82f522973c49e89927L207
bluealloy/revm@ac3fa4f

@sergey-melnychuk sergey-melnychuk changed the title tracking issue: debug build core dumped [Tracking] UB in revm (dup opcode impl) Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant