Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a noise when playing on iOS after upgrade audioinput to 1.0.2. Works well on Android. #101

Open
wangzhengbo opened this issue Sep 16, 2019 · 7 comments
Labels
bug This is an identified bug that should be fixed. help wanted The great thing about open-source is that everyone can contribute!

Comments

@wangzhengbo
Copy link

There is a noise when playing on iOS after upgrade audioinput to 1.0.2. Works well on Android.
Because 1.0.2 normalize to typed array.

@Merwan1010
Copy link

Merwan1010 commented Sep 19, 2019

What kind of noise is that ?

I noticed that i had some crackling noise on the microphone stream when the lightning cable was plugged-in the iphone. I shot a video for you, tell me if this is a similar noise.

Youtube Link

@edimuj
Copy link
Owner

edimuj commented Sep 20, 2019

Thanks for the video! Hmm, I haven't experienced that type of issue with the captured sound. Anyone else having this issue?

Ok, I was a bit to fast to accept a PR which resulted in 1.0.2 and which includes the typed array stuff. So using 1.0.1 instead should work on iOS?

@edimuj edimuj added analysis needed This is a question or potential bug that needs further analysis. help wanted The great thing about open-source is that everyone can contribute! labels Sep 20, 2019
@edimuj
Copy link
Owner

edimuj commented Sep 20, 2019

Have you seen issue #100 ?

@wangzhengbo
Copy link
Author

Have you seen issue #100 ?

It's fixed by remove the code added by 'Add support for typed arrays with audio data'. See e7b9703#diff-fb1aa34c5c08ae27df513638cb93666f

So can you add an option to toggle the feature 'Add support for typed arrays with audio data'.
Default to enable it and i can upgrade to the latest version and disable this option in my project.

@wangzhengbo
Copy link
Author

Thanks for the video! Hmm, I haven't experienced that type of issue with the captured sound. Anyone else having this issue?

Ok, I was a bit to fast to accept a PR which resulted in 1.0.2 and which includes the typed array stuff. So using 1.0.1 instead should work on iOS?

Yes, it's work well on iOS with 1.0.1.

@edimuj
Copy link
Owner

edimuj commented Dec 31, 2019

Thanks for checking 1.0.1 on iOS @wangzhengbo !

Will try to dig into this in the coming weeks. I agree, making the typed arrays optional would take away a lot of headache.

@edimuj edimuj added bug This is an identified bug that should be fixed. and removed analysis needed This is a question or potential bug that needs further analysis. labels Dec 31, 2019
@sertal70
Copy link
Contributor

Just a note: I also had noise with v1.0.2 recording in iOS but it disappeared as soon as I switched channels from STEREO to MONO in recording configuration. STEREO works well on Android only, MONO works in both Android and iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is an identified bug that should be fixed. help wanted The great thing about open-source is that everyone can contribute!
Projects
None yet
Development

No branches or pull requests

4 participants