Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm removal of array element #31

Open
yaffol opened this issue Jan 20, 2022 · 1 comment
Open

Confirm removal of array element #31

yaffol opened this issue Jan 20, 2022 · 1 comment

Comments

@yaffol
Copy link
Contributor

yaffol commented Jan 20, 2022

When an array element is requested to be deleted, a confirmation dialog should pop-up with the option to go ahead or cancel.

Example https://xd.adobe.com/view/630ba25a-8e83-45b8-be30-c41b146167e1-3658/screen/1cbe26ed-340b-4ee2-9947-3730c8e70f8f/

Ideally the dialog should use the label of the array group within its message - eg Delete ArrayLabel?
@sdirix sdirix mentioned this issue Jan 30, 2022
Merged
@sdirix
Copy link
Member

sdirix commented Jan 31, 2022

With #34 the confirmation dialog is now implemented for the array layout renderer.

It should also be implemented for the table renderer and its messages should be transalatable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaffol @sdirix