Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paste into find overlay control does not work in multipage editor (manifest.mf, plugin.xml) #2509

Closed
2 tasks done
Tracked by #2021
tobiasmelcher opened this issue Nov 8, 2024 · 3 comments
Closed
2 tasks done
Tracked by #2021

Paste into find overlay control does not work in multipage editor (manifest.mf, plugin.xml) #2509

tobiasmelcher opened this issue Nov 8, 2024 · 3 comments
Assignees
@HeikoKlare
Labels
bug Something isn't working
Milestone
4.34 RC1

Comments

@tobiasmelcher
Copy link
Contributor

Steps to reproduce

From a fresh installation and clean workspace:

  • import an eclipse plugin project
  • open a MANIFEST.MF file
  • select the word "qualifier" in the text editor and press CTRL-C to copy the text into the clipboard
  • select another word in the text editor, e.g. "plugin"
  • press CTRL-F to open the new find overlay control shown inplace of the text editor. The word "plugin" is taken over in the find overlay which is correct. I expect that the find overlay control now has the focus.
  • now press CTRL-V to paste "qualifier" into the find overly search control -> this is currently not the case, the word "qualifier" from the clipboard is pasted into the text editor and not into the find overlay

The same steps work fine in the Java source editor, but not in a multipage editor containing a text editor as page.
Screencast:

screencast_paste_into_find_overlay.mp4

Tested under this environment:

  • OS & version: Windows
  • Eclipse IDE/Platform version (as shown in Help > About): ...
  • eclipse-SDK-I20241107-1800-win32-x86_64

Community

  • I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
@tobiasmelcher tobiasmelcher added the bug Something isn't working label Nov 8, 2024
@tobiasmelcher tobiasmelcher mentioned this issue Nov 8, 2024
Open
66 tasks
@HeikoKlare HeikoKlare mentioned this issue Nov 9, 2024
Open
@HeikoKlare
Copy link
Contributor

Additional information: this also happens in other editors (like Java source code editor) when pasting into the replace input field.

HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Nov 11, 2024
@HeikoKlare
Find/replace overlay: allow pasting into replace input field eclipse-…
190a2da 
…platform#2509

While actions of the target editor are properly deactivated when the
find input field of the FindReplaceOverlay has focus, the same does not
happen for the replace input field. In consequence, for example, you
cannot paste clipboard content into the replace input field via the
according keyboard shortcut (CTRL+V).

With this change, the functionality to deactivate target editor actions
is also applied when the the replace input field has focus, in addition
to the find input field.

Contributes to
eclipse-platform#2509
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Nov 11, 2024
@HeikoKlare
Find/replace overlay: allow pasting into replace input field eclipse-…
ff1b790 
…platform#2509

While actions of the target editor are properly deactivated when the
find input field of the FindReplaceOverlay has focus, the same does not
happen for the replace input field. In consequence, for example, you
cannot paste clipboard content into the replace input field via the
according keyboard shortcut (CTRL+V).

With this change, the functionality to deactivate target editor actions
is also applied when the the replace input field has focus, in addition
to the find input field.

Contributes to
eclipse-platform#2509
@HeikoKlare HeikoKlare mentioned this issue Nov 11, 2024
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Nov 12, 2024
@HeikoKlare
Find/replace overlay: allow pasting in multi-page editors eclipse-pla…
4ffc6f6 
…tform#2509

While actions of the target editor are properly deactivated when the
target is an ordinary, single-page editor, the same does not happen when
the target is a multi-page editor. In consequence, for example, you
cannot paste clipboard content into the overlay via the according
keyboard shortcut (CTRL+V), but it will paste into the target editor
instead.

With this change, the functionality to deactivate target editor actions
is extended to also deactivate the relevant global actions (cut, copy,
paste, etc.) that editors like multi-page editors fall back to.

Fixes to
eclipse-platform#2509
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Nov 12, 2024
@HeikoKlare
Find/replace overlay: allow pasting into replace input field eclipse-…
dfa5bd5 
…platform#2509

While actions of the target editor are properly deactivated when the
find input field of the FindReplaceOverlay has focus, the same does not
happen for the replace input field. In consequence, for example, you
cannot paste clipboard content into the replace input field via the
according keyboard shortcut (CTRL+V).

With this change, the functionality to deactivate target editor actions
is also applied when the the replace input field has focus, in addition
to the find input field.

Contributes to
eclipse-platform#2509
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Nov 12, 2024
@HeikoKlare
Find/replace overlay: allow pasting into replace input field eclipse-…
7e9c897 
…platform#2509

While actions of the target editor are properly deactivated when the
find input field of the FindReplaceOverlay has focus, the same does not
happen for the replace input field. In consequence, for example, you
cannot paste clipboard content into the replace input field via the
according keyboard shortcut (CTRL+V).

With this change, the functionality to deactivate target editor actions
is also applied when the the replace input field has focus, in addition
to the find input field.

Contributes to
eclipse-platform#2509
HeikoKlare added a commit that referenced this issue Nov 12, 2024
@HeikoKlare
Find/replace overlay: allow pasting into replace input field #2509
64af72a 
While actions of the target editor are properly deactivated when the
find input field of the FindReplaceOverlay has focus, the same does not
happen for the replace input field. In consequence, for example, you
cannot paste clipboard content into the replace input field via the
according keyboard shortcut (CTRL+V).

With this change, the functionality to deactivate target editor actions
is also applied when the the replace input field has focus, in addition
to the find input field.

Contributes to
#2509
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Nov 12, 2024
@HeikoKlare
Find/replace overlay: allow pasting in multi-page editors eclipse-pla…
26e31ce 
…tform#2509

While actions of the target editor are properly deactivated when the
target is an ordinary, single-page editor, the same does not happen when
the target is a multi-page editor. In consequence, for example, you
cannot paste clipboard content into the overlay via the according
keyboard shortcut (CTRL+V), but it will paste into the target editor
instead.

With this change, the functionality to deactivate target editor actions
is extended to also deactivate the relevant global actions (cut, copy,
paste, etc.) that editors like multi-page editors fall back to.

Fixes to
eclipse-platform#2509
@HeikoKlare HeikoKlare mentioned this issue Nov 12, 2024
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Nov 12, 2024
@HeikoKlare
Find/replace overlay: allow pasting in multi-page editors eclipse-pla…
5c7a21c 
…tform#2509

While actions of the target editor are properly deactivated when the
target is an ordinary, single-page editor, the same does not happen when
the target is a multi-page editor. In consequence, for example, you
cannot paste clipboard content into the overlay via the according
keyboard shortcut (CTRL+V), but it will paste into the target editor
instead.

With this change, the functionality to deactivate target editor actions
is extended to also deactivate the relevant global actions (cut, copy,
paste, etc.) that editors like multi-page editors fall back to.

Fixes to
eclipse-platform#2509
HeikoKlare added a commit that referenced this issue Nov 12, 2024
@HeikoKlare
Find/replace overlay: allow pasting in multi-page editors #2509
69f6e45 
While actions of the target editor are properly deactivated when the
target is an ordinary, single-page editor, the same does not happen when
the target is a multi-page editor. In consequence, for example, you
cannot paste clipboard content into the overlay via the according
keyboard shortcut (CTRL+V), but it will paste into the target editor
instead.

With this change, the functionality to deactivate target editor actions
is extended to also deactivate the relevant global actions (cut, copy,
paste, etc.) that editors like multi-page editors fall back to.

Fixes to
#2509
@HeikoKlare
Copy link
Contributor

Fixed via:

I used a wrong tag, so that this issue was not auto-closed by merging that PR.

@tobiasmelcher
Copy link
Contributor Author

Thanks a lot. Fix is also working fine in the Abap Development Tools source editors.

@BeckerWdf BeckerWdf added this to the 4.34 RC1 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeikoKlare HeikoKlare

Labels
bug Something isn't working
Projects
None yet
Milestone
4.34 RC1
Development

No branches or pull requests
3 participants
@HeikoKlare @tobiasmelcher @BeckerWdf