[master] IndexOutOfBoundsException when JPQL has embeddable or relational attributes without the optional entity identification variable - bugfix and unit tests #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibutes without the optional entity identification variable - bugfix and unit tests Signed-off-by: Radek Felcman <[email protected]>
Signed-off-by: Radek Felcman <[email protected]>
Signed-off-by: Radek Felcman <[email protected]>
rfelcman
force-pushed
the
jpql_relational_variable_this
branch
from
1a7aca9
to
12d7c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2188
Location and execution context of this fix is different, than other
thisfixes.This one is located in
org.eclipse.persistence.jpa.jpql.AbstractSemanticValidator#validateStateFieldPathExpressionand executed byorg.eclipse.persistence.internal.jpa.jpql.HermesParser#validateinorg.eclipse.persistence.coremodule when project and descriptors are available. Reason behind this is, that code has to distinguish between possible Enum or mapping path, which is not available in JPQL parser context.