Skip to content
This repository has been archived by the owner on Apr 28, 2022. It is now read-only.

Workspace names are printed to console when they shouldn't be #11

Open
cinnamon-bun opened this issue Feb 8, 2021 · 0 comments
Open

Workspace names are printed to console when they shouldn't be #11

cinnamon-bun opened this issue Feb 8, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@cinnamon-bun
Copy link
Member

cinnamon-bun commented Feb 8, 2021 •
edited
Loading

Only at loglevel 3 should we print workspace names, since they're sensitive information.

Audit the code for console.logs and make sure they're appropriately gated behind loglevel checks

One place thi shappens is "stream: closing stream" and "stream: subscribing to"
@cinnamon-bun cinnamon-bun added the bug Something isn't working label Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cinnamon-bun