generated from dxw/rails-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement javascript handlers for UI interactions #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickjfl
force-pushed
the
83-implement-js-handlers-for-ui-interactions
branch
from
October 18, 2024 14:45
8344037
to
39be0f8
Compare
patrickjfl
force-pushed
the
83-implement-js-handlers-for-ui-interactions
branch
from
October 21, 2024 14:10
39be0f8
to
45f6094
Compare
good points, all actioned i believe :) |
edavey
approved these changes
Oct 22, 2024
Also removes the blue ticks from the dropdown, which are probably redundant for our single-select use case.
patrickjfl
force-pushed
the
83-implement-js-handlers-for-ui-interactions
branch
from
October 22, 2024 14:37
45f6094
to
6f9730c
Compare
Once we've got a comprehensive integration test for the new styled forecasts page (`/styled_forecast`), including the air quality alerts, we will refactor the prediction classes - rename `#name` to be a single word ("UV") - move the display name ("Ultraviolet rays (UV)") to translation file fron where it can be accessed by `PredictionComponent` - remove `#guidance`. This belongs in the new `PredictionComponent`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Implements JS handlers for the location selection menu, pollutant selection menu, and toggling guidance for predictions. Trello ticket: https://trello.com/c/1IWw81ee/83-implement-js-handlers-for-ui-interactions
Screenshots of UI changes
Before
After
Next steps
accessibility testing
on this feature.