Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement javascript handlers for UI interactions #55

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

patrickjfl
Copy link
Contributor

@patrickjfl patrickjfl commented Oct 18, 2024

Changes in this PR

Implements JS handlers for the location selection menu, pollutant selection menu, and toggling guidance for predictions. Trello ticket: https://trello.com/c/1IWw81ee/83-implement-js-handlers-for-ui-interactions

Screenshots of UI changes

Screenshot 2024-10-18 at 15 06 32

Screenshot 2024-10-18 at 15 07 52

Before

After

Next steps

@patrickjfl patrickjfl requested a review from nicky October 18, 2024 14:10
@patrickjfl patrickjfl force-pushed the 83-implement-js-handlers-for-ui-interactions branch from 8344037 to 39be0f8 Compare October 18, 2024 14:45
@patrickjfl
Copy link
Contributor Author

@edavey
Copy link
Collaborator

edavey commented Oct 21, 2024

Nicely done. Just a few small questions (see screenshots):

  1. should we go a bit further with the "selection-made" event handler? to close the drop down and display the selected option?
  2. are we planning to retain the blue "checks" or "ticks" in the zone selector? Perhaps they are most useful for a multi-select list, which is not the case here? So perhaps we could just lose the ticks?
  3. the control for expanding / collapsing the prediction details ought to be right aligned I think?
close_on_select tick_against_selection

chevrons-right-aligned

@patrickjfl patrickjfl force-pushed the 83-implement-js-handlers-for-ui-interactions branch from 39be0f8 to 45f6094 Compare October 21, 2024 14:10
@patrickjfl
Copy link
Contributor Author

Nicely done. Just a few small questions (see screenshots):

1. should we go a bit further with the "selection-made" event handler? to close the drop down and display the selected option?

2. are we planning to retain the blue "checks" or "ticks" in the zone selector? Perhaps they are most useful for a multi-select list, which is not the case here? So perhaps we could just lose the ticks?

3. the control for expanding / collapsing the prediction details ought to be right aligned I think?

close_on_select tick_against_selection

chevrons-right-aligned

good points, all actioned i believe :)

@patrickjfl patrickjfl force-pushed the 83-implement-js-handlers-for-ui-interactions branch from 45f6094 to 6f9730c Compare October 22, 2024 14:37
Once we've got a comprehensive integration test for the new
styled forecasts page (`/styled_forecast`), including the air
quality alerts, we will refactor the prediction
classes

- rename `#name` to be a single word ("UV")

- move the display name ("Ultraviolet rays (UV)") to translation
file fron where it can be accessed by `PredictionComponent`

- remove `#guidance`. This belongs in the new
`PredictionComponent`
@edavey edavey merged commit 604fbec into develop Oct 23, 2024
2 checks passed
@edavey edavey deleted the 83-implement-js-handlers-for-ui-interactions branch October 23, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants