Refactor temperature, UV and pollen predictions #46
+55
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to render these names in our prediction components.
Because temperature doesn’t have an associated DAQI level, it makes sense to use a different partial.
It still makes sense to add a ‘v2’ suffix to these methods to easily differentiate them from the v1 code that we will shortly remove.
patrickjfl
force-pushed
the
refactor-prediction-partial
branch
from
09afa3d
to
014e6bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
This PR updates the temperature, UV and pollen predictions on the new forecast page to use reusable components with live data, moving beyond the naive implementation of the designs we have used for predictions until this point.
The temperature prediction is a little different from UV and pollen in that it doesn't have an associated DAQI level, which means it would be awkward to use the same component for all three, so I have instead created a dedicated partial for the temperature prediction.
Screenshots of UI changes
Before
After
Next steps
accessibility testing
on this feature.