Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rusk-wallet: Rename --profile to --wallet #2682

Open
HDauven opened this issue Oct 16, 2024 · 0 comments · May be fixed by #2781
Open

rusk-wallet: Rename --profile to --wallet #2682

HDauven opened this issue Oct 16, 2024 · 0 comments · May be fixed by #2781
Labels
module:rusk-wallet Issues related to rusk wallet type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@HDauven
Copy link
Member

HDauven commented Oct 16, 2024

Summary

We currently use a wallet -> profile -> account(shielded, public) hierarchy. The --profile flag is used in a different way. The profile is in essence a new folder in which a wallet is maintained.

Possible solution design or implementation

We should rename --profile to --wallet. This is a breaking change and the flag is actively used in multiple locations. We need to be sure the flag is updated properly everywhere, like some of our tools and the faucet.

@HDauven HDauven added type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) module:rusk-wallet Issues related to rusk wallet labels Oct 16, 2024
@HDauven HDauven assigned moCello and unassigned moCello Oct 16, 2024
@HDauven HDauven linked a pull request Oct 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:rusk-wallet Issues related to rusk wallet type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants