Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Max) number of bytes in an auto-generated challenge is not documented #188

Closed
lgarron opened this issue Nov 11, 2023 · 3 comments · Fixed by #198
Closed

(Max) number of bytes in an auto-generated challenge is not documented #188

lgarron opened this issue Nov 11, 2023 · 3 comments · Fixed by #198

Comments

@lgarron
Copy link

lgarron commented Nov 11, 2023

I can't find documentation of the number of bytes (or at least a maximum) at:

Since this is a binary value that must be stored on the server, it would be really useful to know what size to allocate in a DB column.

(I know I can work around this by specifying the challenge, but it would be useful to know how to handle the defaults.)

@MasterKale
Copy link
Collaborator

Thanks for raising this @lgarron, if only I had time lately to produce a proper docs site 🥲

Until then I can add a note or something to the README about this specifically.

@MasterKale
Copy link
Collaborator

I've merged #198 that communicates more clearly how big challenges will be when it's left up to the library to generate them (it's 64 bytes.)

I'll follow up when this is available in a new release on PyPI.

@MasterKale
Copy link
Collaborator

Alright, this change is out in the latest webauthn==2.0.0 on PyPI:

https://github.com/duo-labs/py_webauthn/releases/tag/v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants