-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spell Design] Missing Context on Aave Macro #5504
Comments
Hi @lgingerich - I used existing spells at the time of adding this macro (one of my early on Spellbook projects). Adding |
|
The current macro for Aave V3 has a single column for the user on borrows.
aave_v3_ethereum.Pool_evt_Borrow
has two columns that relate to the user:user
andonBehalfOf
. From a quick look, this also affects Aave V2, but I didn't check beyond that.By omitting data in
onBehalfOf
, there is missing context inlending.borrow
. It's not possible to calculate net borrow/lend since we don't know who's account funds were borrowed from.So we need to add this
onBehalfOf
column back in somehow. I'm imagining we want to have both columns and not just swap these out. I wasn't part of the creation of the Aave model or any borrow/lend stuff, so I wanted to open an issue and get input from those that did work on it.cc: @Hosuke @tomfutago @jeff-dude
The text was updated successfully, but these errors were encountered: