Skip to content

Latest commit

 

History

History
55 lines (32 loc) · 2.36 KB

CONTRIBUTING.md

File metadata and controls

55 lines (32 loc) · 2.36 KB

Add a fact to the app and then open a PR

Points to note

  • No spam
  • Don't post duplicate facts
  • Ensure the fact you're posting is decent and SFW

Steps to add fact to app


image


Find a good fact, its source, and an image related to it. Pass the fact as a string to info, source to source , and after adding image to Android Studio using Resource Manager, the image resource id to imageId . Also pass the type of the fact as one of the following types depending on relevence:


image


Finally pass your GitHub user id as the submittedBy parameter.

All these must be passed to the list in Datasource.kt file wrapped in the object of data class Fact

How to make Changes

  1. Fork the repository.

Commit your update

Commit the changes once you are happy with them.

Pull Request

When you're finished with the changes, create a pull request, also known as a PR.

  • Fill the PR template so that we can review your PR. This template helps reviewers understand your changes as well as the purpose of your pull request.
  • Ensure Allow edits by maintainers is ticked
  • Once you submit your PR, a team member will review your proposal. We may ask questions or request for additional information.
  • If any changes are required make it accordingly to the same PR
  • If you run into any merge issues, checkout this Resolving Conflicts to help you resolve merge conflicts and other issues.

Your PR is merged!