Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all dunder functions to use the normal function signature #4

Open
thepabloaguilar opened this issue Jul 11, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest event

Comments

@thepabloaguilar
Copy link
Member

When we define a class like this:

def func():
    ...

class MyClass:
    my_func = lambda self, arg: arg

# or
class MyAnotherClass:
    my_func = func

The coverage plugin will consider the my_func as coveraged without any tests.
This behavior is expected because for it the my_func is an attribute!

I think it will be great use the normal signature, this will enforce we to make dummy tests to ensures the _ will work correctly.

@thepabloaguilar thepabloaguilar changed the title Convert all dunder functions to use the normal signature Convert all dunder functions to use the normal function signature Jul 11, 2020
@thepabloaguilar thepabloaguilar added enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest event labels Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest event
Development

No branches or pull requests

1 participant