-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSD or MIT #9
Comments
I believe the LICENSE file is correct. I will change the cargo.toml |
This issue is still present in the latest published version, 2.3.2. |
A follow up question regarding this. The context.rs file seems to be owned by google, and only licensed under MIT: https://github.com/dropbox/rust-brotli-decompressor/blob/master/src/context.rs#L7 Is there some documentation somewhere that indicates that this file can be distributed under the BSD license? |
This issue is still present in the latest published version, 2.3.4. The unclear license of this project is making it difficult to distribute any software that includes it. If parts of the source code are indeed covered by MIT license, then a copy of the MIT license text would need to be included in published crates in addition to the BSD-3-Clause license text. Edit: Of course, if portions of the code are covered by BSD-3-Clause and other portions are MIT licensed, then the correct specifier in Cargo.toml would be |
Since `src/context.rs` appears to be derived from https://github.com/google/brotli/blob/v1.1.0/c/common/context.c (possibly at a different version), and carries only MIT terms, it’s not possible for the crate to be `BSD-3-Clause OR MIT` overall. The new `LICENSE.MIT` file is taken from https://github.com/google/brotli/raw/refs/tags/v1.1.0/LICENSE since that appears to be the correct license text for `context.rs`. Fixes dropbox#9. Signed-off-by: Benjamin A. Beasley <[email protected]>
Hello, Cargo.toml lists
BSD OR MIT
, however LICENSE file contains only info about BSD... Who is right?The text was updated successfully, but these errors were encountered: