-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub CommitListOptions Parameter is Out of Date #76
Comments
jstrachan
pushed a commit
to jstrachan/go-scm
that referenced
this issue
Dec 22, 2020
feat: Move internal/hmac to pkg/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems to me that one of
Git.ListCommits
argumentsCommitListOptions
requires updating.It uses
ref
to query commits from branch, but the GitHub official documentation (List Commits Parameters) says the query parameter should besha
Using
ref
to query branch commits will always return commits from default (master) branch.Please let me know if I am wrong. I could also create PR to update it if needed.
The text was updated successfully, but these errors were encountered: