Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the loss function in your paper #2

Open
liulizuel opened this issue Jul 3, 2023 · 2 comments
Open

Question about the loss function in your paper #2

liulizuel opened this issue Jul 3, 2023 · 2 comments

Comments

@liulizuel
Copy link

liulizuel commented Jul 3, 2023

In your paper, the equation (3) and (8) for loss function read,
𝑝 ∈ {𝑝+ } ∩ N, or 𝑝 ∈ {𝑝+ } ∩ N^mix
I don't know why you use intersection instead of union.
Each batch in your loss function consists of positive passages and negative passages.
So I think it confuses me when you use '∩' to represent intersection here.

@drogozhang
Copy link
Owner

Thank you so much for the great catch! You are 100% correct and I will fix these typos in our next version.

Best,
Kai

@liulizuel
Copy link
Author

Thank you for your timely response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants