Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setting hostRequirements for Codespaces #75680

Closed
vcsjones opened this issue Sep 15, 2022 · 2 comments
Closed

Consider setting hostRequirements for Codespaces #75680

vcsjones opened this issue Sep 15, 2022 · 2 comments
Assignees
Milestone

Comments

@vcsjones
Copy link
Member

vcsjones commented Sep 15, 2022

Today, if I go to the dotnet/runtime repository to create a Codespace with the default configuration from the Code button (without clicking the chevron):

image

This will create a codespaces with 2 cores and 4 GB of RAM. Even with a pre-built container, this offers a somewhat rough experience. Between the VS Code and server-side extensions using some resources, running ./dotnet.sh test src/libraries/System.Security.Cryptography/tests will OOM.

image

While it would be nice if things worked in this configuration for folks that want to use the lowest possible billing rate, the frequent OOMs I encountered while using this configuration make me think we need to set a floor on the Codespaces configuration.

You can do this with the hostRequirements section in .devcontainer/devcontainer.json. I am proposing we add this:

"hostRequirements": {
   "cpus": 4,
   "memory": "8gb"
}

Folks can always change the specs after they create the codespaces, but it just ends up in a little bit of wasted time and friction trying to do it with the minimum spec.

Documentation on is available on our docs.

/cc @eerhardt

@ghost
Copy link

ghost commented Sep 15, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Today, if I go to the dotnet/runtime repository to create a Codespace with the default configuration from the Code button:

image

This will create a codespaces with 2 cores and 4 GB of RAM. Even with a pre-built container, this offers a somewhat rough experience. Between the VS Code and server-side extensions using some resources, running ./dotnet.sh test src/libraries/System.Security.Cryptography/tests will OOM.

image

While it would be nice if things worked in this configuration for folks that want to use the lowest possible billing rate, the frequent OOMs I encountered while using this configuration make me think we need to set a floor on the Codespaces configuration.

You can do this with the hostRequirements section in .devcontainer/devcontainer.json. I am proposing we add this:

"hostRequirements": {
   "cpus": 4,
   "memory": "8gb"
}

Folks can always change the specs after they create the codespaces, but it just ends up in a little bit of wasted time and friction trying to do it with the minimum spec.

Documentation on is available on our docs.

/cc @eerhardt

Author: vcsjones
Assignees: -
Labels:

area-Meta

Milestone: -

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 15, 2022
@eerhardt
Copy link
Member

I'm updating the Codespaces configuration with #74683. I can include this change in there as well.

eerhardt added a commit to eerhardt/runtime that referenced this issue Sep 15, 2022
Developing in dotnet/runtime with a 2-core / 4GB ram machine doesn't work very well. Add a minimum of 4-core machine to the devcontainer spec.

Fix dotnet#75680
@eerhardt eerhardt self-assigned this Sep 15, 2022
@eerhardt eerhardt added this to the 8.0.0 milestone Sep 15, 2022
@eerhardt eerhardt removed the untriaged New issue has not been triaged by the area owner label Sep 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants