Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup duplicating targets #9565

Open
YuliiaKovalova opened this issue Oct 21, 2024 · 2 comments
Open

Cleanup duplicating targets #9565

YuliiaKovalova opened this issue Oct 21, 2024 · 2 comments
Labels
Triage-Investigate Reviewed and investigation needed by dev team

Comments

@YuliiaKovalova
Copy link
Member

Summary

Common to both project systems design time build targets were added to https://devdiv.visualstudio.com/DevDiv/_git/ProjectServices/commit/fecd52a99dfab9ac1a6896ce4b4271cb5015da7e?refName=refs/heads/main&path=/src/Microsoft.VisualStudio.ProjectServices/Microsoft.DesignTime.targets

Feel free to cleanup the duplicating targets:
CollectCopyToOutputDirectoryItemDesignTime
CompileDesignTime
_CheckCompileDesignTimePrerequisite

User Impact

No visible impact. The listed targets are delivered in VS as a part of ProjectServices insertion and imported by msbuild
https://github.com/dotnet/msbuild/pull/10732/files

@YuliiaKovalova YuliiaKovalova added the good-first-issue [up-for-grabs] Good for learning and for external contributors. Relatively self-contained. label Oct 21, 2024
@drewnoakes
Copy link
Member

@YuliiaKovalova if I understand dotnet/msbuild#10732 and dotnet/msbuild#10698, then we would expect the ProjectServices's Microsoft.DesignTime.targets to be available in VS and imported by MSBuild already, so it would just be a case of diffing the implementations and removing ours if possible. Does that sound right?

@YuliiaKovalova
Copy link
Member Author

Yes, it's correct. MSBuild will resolve the case for the targets duplicates.
Since ProjectService is shipped with VS even with the bare workload installation, we decided to keep you posted on this possible cleanup.

@haileymck haileymck added Triage-Investigate Reviewed and investigation needed by dev team and removed good-first-issue [up-for-grabs] Good for learning and for external contributors. Relatively self-contained. labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage-Investigate Reviewed and investigation needed by dev team
Projects
None yet
Development

No branches or pull requests

3 participants