Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed Resources Editor (Legacy) corrupts Resources.resx and Resources.Designer.cs file #9532

Open
th-joerger opened this issue Sep 12, 2024 · 0 comments
Assignees
Labels
Feature-Resource-Designer The legacy resource file (RESX) editor. Feature-Resource-Explorer The modern Resource Explorer for editing and managing RESX and RESW files. Triage-Investigate Reviewed and investigation needed by dev team
Milestone

Comments

@th-joerger
Copy link

Visual Studio Version

17.12.0 Preview 1.0

Summary

Managed Resources Editor (Legacy) corrupts Resources.resx and Resources.Designer.cs file.

Steps to Reproduce

  1. Open Resources.resx with Managed Resources Editor (Legacy).
  2. Perform any change on a file resource and save.
  3. In Resources.resx, reference to utf-8 are removed. In Resources.Designer.cs, auto-generated comments are borked as well.
<data name="LabDescription" type="System.Resources.ResXFileRef, System.Windows.Forms">
-    <value>..\Resources\LabDescription.txt;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=c44a5c334534e089;utf-8</value>
+    <value>..\Resources\LabDescription.txt;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=c44a5c334534e089</value>
</data>

Expected Behavior

Parse file correctly and don't mess up when saving.

Actual Behavior

Parse file incorrectly and mess up saving.

User Impact

Huge file Resources.Designer.cs corrupted.

@drewnoakes drewnoakes added Triage-Investigate Reviewed and investigation needed by dev team Feature-Resource-Designer The legacy resource file (RESX) editor. Feature-Resource-Explorer The modern Resource Explorer for editing and managing RESX and RESW files. labels Oct 10, 2024
@drewnoakes drewnoakes added this to the 17.13 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Resource-Designer The legacy resource file (RESX) editor. Feature-Resource-Explorer The modern Resource Explorer for editing and managing RESX and RESW files. Triage-Investigate Reviewed and investigation needed by dev team
Projects
None yet
Development

No branches or pull requests

3 participants