Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning-to-error promotion process is doubled #10891

Open
rainersigwald opened this issue Oct 25, 2024 · 0 comments
Open

Warning-to-error promotion process is doubled #10891

rainersigwald opened this issue Oct 25, 2024 · 0 comments
Labels
Priority:2 Work that is important, but not critical for the release triaged

Comments

@rainersigwald
Copy link
Member

The current warnings-as-errors and warnings-not-as-errors process is applied multiple times in multiproc builds:

  • in the warning-logging process, to create the events to be sent to the main node, and
  • In the main logging node's LoggingService.

That's wasteful and can lead to confusing re-promotion behavior bugs like #10874.
@maridematte maridematte added Priority:2 Work that is important, but not critical for the release triaged labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority:2 Work that is important, but not critical for the release triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rainersigwald @maridematte