Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Semgrep to workflows #30610

Closed
spbolton opened this issue Nov 8, 2024 · 1 comment · Fixed by #30611 or #30620
Closed

Add Semgrep to workflows #30610

spbolton opened this issue Nov 8, 2024 · 1 comment · Fixed by #30611 or #30620
Assignees
@spbolton

Comments

@spbolton
Copy link
Contributor

spbolton commented Nov 8, 2024 •
edited
Loading

Following these guidelines we need to add semgrep as a replacement for sonarqube in our PR and trunk workflows

https://semgrep.dev/docs/deployment/add-semgrep-to-ci
@spbolton spbolton converted this from a draft issue Nov 8, 2024
@spbolton spbolton self-assigned this Nov 8, 2024
@spbolton spbolton linked a pull request Nov 8, 2024 that will close this issue
ci: Add Semgrep to workflows (#30610) #30611
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

PRs:

github-merge-queue bot pushed a commit that referenced this issue Nov 11, 2024
@spbolton
ci: Add Semgrep to workflows (#30610) (#30611)
4a3241d 
### Proposed Changes
* enable semgrep in workflows in parallel with sonarqube
* add ability to use github vars DISABLE_SONAR=true and
DISABLE_SEMGREP=true on the repository to disable if issues without
pushing code change
setting vars.SEMGREP_NO_FAIL=true will run Semgrep unless it is
disabled, but will not fail the workflow step
@github-project-automation github-project-automation bot moved this from Next 1-3 Sprints to Internal QA in dotCMS - Product Planning Nov 11, 2024
@github-actions github-actions bot mentioned this issue Nov 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 11, 2024
@spbolton
ci(semgrep): Fix trunk workflow for semgrep step passing artifact run…
b919bba 
… id (#30610) (#30620)

### Proposed Changes
* Error in trunk workflow due to artifact run id not being passed into
semgrep workflow


https://github.com/dotCMS/core/actions/runs/11782551202/job/32817867816#step:3:228
@github-actions github-actions bot mentioned this issue Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spbolton spbolton

Labels
None yet
Projects
dotCMS - Product Planning
Status: Internal QA
Milestone
No milestone
1 participant
@spbolton