Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Test CircuitBreakerUrlTest.testGet and RemoteAnnouncementsLoaderIntegrationTest.TestAnnouncementsLoader #30420

Closed
erickgonzalez opened this issue Oct 22, 2024 · 1 comment · Fixed by #30422
Closed

Fix Test CircuitBreakerUrlTest.testGet and RemoteAnnouncementsLoaderIntegrationTest.TestAnnouncementsLoader #30420

erickgonzalez opened this issue Oct 22, 2024 · 1 comment · Fixed by #30422
Assignees
@erickgonzalez
Labels
Priority : 1 Show Stopper QA : Not Needed Release : 23.10.24 v18 Included in LTS patch release 23.10.24 v18 Release : 24.04.24 v10 Included in LTS patch release 24.04.24 v10 Release : 24.10.25 Bug Fixing Team : Bug Fixers Type : Task

Comments

@erickgonzalez
Copy link
Contributor

erickgonzalez commented Oct 22, 2024 •
edited
Loading

Parent Issue

No response

Task

With the redesign of dotcms.com, we broke the CircuitBreakerUrlTest.testGet.

Also we broke RemoteAnnouncementsLoaderIntegrationTest.TestAnnouncementsLoader it's trying to use the content endpoint to get the announcements content but it's trying to be render as page so it throws a 404. Trying the same query against auth it works. This is breaking Announcements feature in all dotcms versions.

Proposed Objective

Code Maintenance

Proposed Priority

Priority 1 - Show Stopper

Acceptance Criteria

Tests must pass without issues, and the announcements feature should work in all dotcms versions.

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@erickgonzalez erickgonzalez self-assigned this Oct 22, 2024
erickgonzalez added a commit that referenced this issue Oct 22, 2024
@erickgonzalez
fix(test): check another string in the response from dotcms.com. ref:#…
283ea20 
…30420
@github-actions GitHub Actions
Copy link

PRs:

@erickgonzalez erickgonzalez changed the title Fix Test CircuitBreakerUrlTest.testGet Fix Test CircuitBreakerUrlTest.testGet and RemoteAnnouncementsLoaderIntegrationTest.TestAnnouncementsLoader Oct 22, 2024
@erickgonzalez erickgonzalez moved this from New to In Progress in dotCMS - Product Planning Oct 22, 2024
erickgonzalez added a commit that referenced this issue Oct 22, 2024
@erickgonzalez
fix(test): check for a tag instead of a content title. ref: #30420
55be6ba
erickgonzalez added a commit that referenced this issue Oct 22, 2024
@erickgonzalez
fix(test
a02e7a3 
): point to https://www2.dotcms.com ref: #30420
@erickgonzalez erickgonzalez added the Next LTS Release Shortlisted of issues that will be included in the upcoming LTS label Oct 22, 2024
erickgonzalez added a commit that referenced this issue Oct 22, 2024
@erickgonzalez
fix(test) ref: #30420
f2c9bf8
@erickgonzalez erickgonzalez moved this from In Progress to In Review in dotCMS - Product Planning Oct 22, 2024
erickgonzalez added a commit that referenced this issue Oct 22, 2024
@erickgonzalez
fix(test) ref: #30420
8f1c329
erickgonzalez added a commit that referenced this issue Oct 22, 2024
@erickgonzalez
#30420 include in 24.04.24 LTS
d9fc770
erickgonzalez added a commit that referenced this issue Oct 22, 2024
@erickgonzalez
#30420 include in 23.10.24 LTS
45b9d8a
github-merge-queue bot pushed a commit that referenced this issue Oct 22, 2024
@erickgonzalez
fix(tests): Several Tests where broken due new dotcms.com site ref:#3…
6d6a3f7 
…0420 (#30422)

This pull request includes a small change to the `CircuitBreakerUrlTest`
test case. The change updates the assertion to check for a different
string in the response content.

*
[`dotcms-integration/src/test/java/com/dotcms/http/CircuitBreakerUrlTest.java`](diffhunk://#diff-a86d291af87dcbb5dfa27d7faa1479a6ca1237bc77d89e38dba28f1cb29d4c26L379-R379):
Updated the assertion in `public void testGet()` to check for the string
"dotCMS empowers brands to simplify content creation" instead of
"/application/themes/dotcms/js/bootstrap.min.js".
@github-actions github-actions bot mentioned this issue Oct 22, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Oct 23, 2024
@erickgonzalez erickgonzalez moved this from Internal QA to Done in dotCMS - Product Planning Oct 23, 2024
@erickgonzalez erickgonzalez added Release : 23.10.24 v18 Included in LTS patch release 23.10.24 v18 Release : 24.04.24 v10 Included in LTS patch release 24.04.24 v10 and removed Next LTS Release Shortlisted of issues that will be included in the upcoming LTS labels Oct 25, 2024
spbolton pushed a commit that referenced this issue Nov 11, 2024
@erickgonzalez @spbolton
fix(tests): Several Tests where broken due new dotcms.com site ref:#3…
44a592d 
…0420 (#30422)

This pull request includes a small change to the `CircuitBreakerUrlTest`
test case. The change updates the assertion to check for a different
string in the response content.

*
[`dotcms-integration/src/test/java/com/dotcms/http/CircuitBreakerUrlTest.java`](diffhunk://#diff-a86d291af87dcbb5dfa27d7faa1479a6ca1237bc77d89e38dba28f1cb29d4c26L379-R379):
Updated the assertion in `public void testGet()` to check for the string
"dotCMS empowers brands to simplify content creation" instead of
"/application/themes/dotcms/js/bootstrap.min.js".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erickgonzalez erickgonzalez

Labels
Priority : 1 Show Stopper QA : Not Needed Release : 23.10.24 v18 Included in LTS patch release 23.10.24 v18 Release : 24.04.24 v10 Included in LTS patch release 24.04.24 v10 Release : 24.10.25 Bug Fixing Team : Bug Fixers Type : Task
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tests): Several Tests where broken due new dotcms.com site ref:#30420 dotCMS/core
2 participants
@erickgonzalez @dotCMS-Machine-User