Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental rendering causes images to be loaded twice #401

Open
matthewp opened this issue Oct 24, 2017 · 2 comments
Open

Incremental rendering causes images to be loaded twice #401

matthewp opened this issue Oct 24, 2017 · 2 comments
Labels
incremental rendering

Comments

@matthewp
Copy link
Contributor

Since images are loaded both by the incremental rendering frame and again in the main document by the application, they will be loaded twice. This can be accounted for if you are using done-ssr/zones/push-images but is a problem if images are served from a CDN because while the images might load fully in the IR frame, when it gets detached the images won't be loaded in the main document.
@matthewp
Copy link
Contributor Author

Not sure this is a bug as it is inherit in doing something multiple times.

@matthewp
Copy link
Contributor Author

matthewp commented Oct 30, 2017 •
edited
Loading

We should probably at least document this, that using done-ssr/zones/push-images and/or cache headers are a good way to go.

@matthewp matthewp mentioned this issue Feb 7, 2018
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
incremental rendering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthewp