Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChipTypeahead wraps input to new line #1742

Open
bitpshr opened this issue Apr 12, 2021 · 1 comment · May be fixed by #1748
Open

ChipTypeahead wraps input to new line #1742

bitpshr opened this issue Apr 12, 2021 · 1 comment · May be fixed by #1748
Assignees

Comments

@bitpshr
Copy link
Member

bitpshr commented Apr 12, 2021

Bug

The ChipTypeahead wraps its input to a new line instead of keeping this inline with the actual chips. This worked prior to the changes introduces as party of #1697.

Package Version: latest

@bitpshr bitpshr self-assigned this Apr 13, 2021
@bitpshr
Copy link
Member Author

bitpshr commented Apr 15, 2021

Leading TypeAhead content is wrapped within a styled span that does things like add margin and font styles required for most types of leading content to look good out-of-the-box. This is all good, but it means that the ChipTypeahead's use of TextInput is broken since these chips are now within a parent span, so the "inline" placement mode is not actually inline (chips are one level lower than the input, so wrapping does not work as expected.) TDLR; there's no way to get chips within a parent to wrap inline with a sibling of that parent, and this is only an issue now that leading content is wrapped for better OOTB styling. I'm struggling to think of a solution that supports the ChipTypeahead's use case ("do not wrap my leading content") while not being hacky (e.g. a wrapLeadiing boolean property, gross.)

cc @agubler @matt-gadd

@bitpshr bitpshr linked a pull request May 3, 2021 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant