Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using "base" in dojo.rc, references to webfonts in /assets are not adjusted #314

Open
arndbeissner opened this issue Feb 12, 2021 · 0 comments

Comments

@arndbeissner
Copy link

Bug

When you use the base property in .dojorc to change the base path to, for example, "/admin/" instead of "/", the generated index.html will be changed properly to reflect that. However, webfont references to locally hosted web fonts (in assets directory) are not changed - they stay at "/assets/". At runtime, the browser will reference /assets/xxx.woff instead of /admin/assets/xx.woff and will not find the webfont. Interestingly, when hosted by the dojo --serve --watch mechanism, this works. When using a production build and moving the content of the list directory to an http server, it doesn't - 404 not finding the resource. All css and js resources are resolved properly.

To be honest I am not entirely why this doesnt work. Creating this issue as discussed in Discord.

Package Version: 7.0.0

Code
hello-world-webfont.zip

Sample based on the default hello world app, with only minimum modifications:

  • add webfont
  • reference webfont in css and set style of Home.m.css to use it
  • set base in .dojorc to /admin/

Expected behavior:

Webfont should be loaded.

Actual behavior:

Webfont is not loaded because the browser tries to load the font from /assets instead of /admin/assets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant