Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "global" cli args in .dojorc file throws #302

Open
devpaul opened this issue Feb 5, 2020 · 0 comments
Open

Using "global" cli args in .dojorc file throws #302

devpaul opened this issue Feb 5, 2020 · 0 comments

Comments

@devpaul
Copy link
Member

devpaul commented Feb 5, 2020

Bug

There are two "global" command line arguments: dojorc and force. When one of these is added to the .dojorc file they throw an exception.

image

This happens currently with the .dojorc file

{
	"create-app": {},
	"build-app": {
		"dojorc": [ ".dojorc" ]
	}
}

This is due to how getOptions() checks against aliases.

A quick fix for this might be to check aliases[key] exists and if it doesn't don't add anything to config. A better feature would be to warn when force or dojorc is used in the .dojorc file and quit gracefully.

Package Version: master

Expected behavior:

I would expect dojorc or force in the .dojorc file would log a warning to the console and quit.

Actual behavior:

An unhandled exception was thrown crashing out of the cli

@devpaul devpaul mentioned this issue Feb 5, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant