Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of Output Module Label during Workflow creation #11171

Open
germanfgv opened this issue Jun 3, 2022 · 1 comment · May be fixed by #11175
Open

Validation of Output Module Label during Workflow creation #11171

germanfgv opened this issue Jun 3, 2022 · 1 comment · May be fixed by #11175

Comments

@germanfgv
Copy link
Contributor

germanfgv commented Jun 3, 2022

Impact of the new feature
WMAgent, T0Agent

Is your feature request related to a problem? Please describe.
T0 production agent was unable to upload blocks of AlCa producers PromptCalibProdSiPixelLorentzAngle and PromptCalibProdSiStripHitEfficiency because the length of the name of their associated output module label was greater than the 45 characters limit in DBS database. A proper validation of such DBS constraints would have prevented this error to reach production configuration.

https://cms-talk.web.cern.ch/t/alcaprompt-datasets-not-loaded-in-dbs/11146

Describe the solution you'd like
Add checks on validateWorkload(), either on StdBase.py, or in PromptReco.py and Express.py.

I'd argue that this should be validated to all kinds of workflows, so I think it makes more sense to add these checks on StdBase.validateWorkload()

Describe alternatives you've considered
We already have masterValidation() to validate input arguments. So it would be possible to simply check the length of the alca skims there. Nonetheless, that would not have a direct correlation with the DBS schema, and it would also not prevent other modules to surpass the 45 char limit

@germanfgv
Copy link
Contributor Author

@amaltaro @todor-ivanov any comments on this request? how do you think it should be implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant